fix(tui): prevent crash when input is undefined in prompt set#7566
Open
Zhanbingli wants to merge 1 commit intoanomalyco:devfrom
Open
fix(tui): prevent crash when input is undefined in prompt set#7566Zhanbingli wants to merge 1 commit intoanomalyco:devfrom
Zhanbingli wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Contributor
|
Unfortunately, this somewhat breaks message forking since the prompt text from the forked message doesn't populate in the input box anymore |
Contributor
|
this one makes more sense to fix the issue: #7702 |
Author
Oh! Thank you! This feedback helps me think about how to improve the code. |
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added defensive checks for the input object in set() and onSelect callbacks. While this specific race condition is hard to reproduce locally, this change directly addresses the undefined error reported in #7528 by ensuring setText is only called on a valid object.